Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

fix(core): Remove duplicate angular interceptor #1107

Merged
merged 1 commit into from
Dec 29, 2015
Merged

fix(core): Remove duplicate angular interceptor #1107

merged 1 commit into from
Dec 29, 2015

Conversation

pgrodrigues
Copy link
Contributor

Remove the interceptor defined in the users module
Update the interceptor defined in the core module
Update the respective test

Fixes #1096

Remove the interceptor defined in the users module
Update the interceptor defined in the core module
Update the respective test

Fixes #1096
@codydaig codydaig added this to the 0.5.0 milestone Dec 16, 2015
@codydaig codydaig self-assigned this Dec 16, 2015
@mleanos
Copy link
Member

mleanos commented Dec 16, 2015

LGTM.

@mleanos
Copy link
Member

mleanos commented Dec 18, 2015

@codydaig @lirantal Do we want to leave the file users.client.config, as a placeholder, but have it empty? Like what we're doing with articles.server.config.

@pgrodrigues
Copy link
Contributor Author

I removed it since there was no js logic to be added to the user config, but I can bring the file back if needed.

@codydaig
Copy link
Member

@mleanos IMO, placeholder files should be in the generator, not laying around in this repo.

@ilanbiala
Copy link
Member

No strong feelings about it, so I'd say let's just keep the repo uncluttered.

@codydaig
Copy link
Member

LGTM

1 similar comment
@rhutchison
Copy link
Contributor

LGTM

codydaig added a commit that referenced this pull request Dec 29, 2015
fix(core): Remove duplicate angular interceptor
@codydaig codydaig merged commit b12be5f into meanjs:master Dec 29, 2015
@codydaig
Copy link
Member

Thanks @pgrodrigues.

Good to see your comments again @rhutchison!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants