This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(articles): Orphaned User reference throws server error #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
LGTM, just squash into 1 commit. |
Adds an additional check for the existence of a populated user reference, when determining if the current user has immediate access to the requested article. Without this fix, the server will throw an error if the requested article doesn't have a populated user field. Modified the article & articles list view's to check if the article has a populated user. If not, then it will display "Deleted User" in place of the missing user reference. Added a server-side test that ensures we can get a single article if the article.user field is referencing a deleted user. Fixes meanjs#1082
mleanos
force-pushed
the
hotfix/Articles-Orphaned-Users
branch
from
704d57a
to
2bdde4e
Compare
|
@lirantal @ilanbiala Squashed |
|
Thanks @mleanos! |
lirantal
added a commit
that referenced
this pull request
Dec 23, 2015
fix(articles): Orphaned User reference throws server error
|
Sure, np! @lirantal |
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional check for the existence of a populated user reference, when determining if the current user has immediate access to the requested article.
Without this fix, the server will throw an error if the requested article doesn't have a populated user field.
Modified the article & articles list view's to check if the article has a populated user. If not, then it will display "Deleted User" in place of the missing user reference.
Fixes #1082