This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
feat(CI): Add Node v6 to Travis CI + remove V5 from allow_failures #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 70.615% when pulling f0b2c12ab3d8f7bbe0ea9d15fe41a0bc97f93827 on simison:patch-17 into 5137214 on meanjs:master. |
|
Coverage remained the same at 70.615% when pulling 92bd8c409efd2cf67c5520dd511e649a22de28f9 on simison:patch-17 into 5137214 on meanjs:master. |
|
v5 seems to be passing atm. Should I remove it from |
|
Yeah we can probably remove it as it seems stable enough |
|
Done + squashed. |
simison
changed the title
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Node v6 to Travis CI, but let it fail.