Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

feat(users): Profile picture cropping, mobile uploading and progress bar #1443

Merged
merged 2 commits into from
Aug 26, 2016

Conversation

hyperreality
Copy link
Contributor

@hyperreality hyperreality commented Aug 24, 2016

feat(users): Profile picture cropping, mobile uploading and progress bar

Improvements to the Change Profile Picture page including:

  • The option to take a camera pic and upload it is now offered on mobile
  • Large images (such as those taken from a camera) no longer crash the page
  • Add ability to crop pictures using ngImgCrop
  • Add progress bar during uploading
  • Large images are now properly resized to thumbnails
  • Much of this was accomplished by switching from the angular-file-upload
    module to the far more fully-featured and frequently-updated ng-file-upload

hyperreality and others added 2 commits August 24, 2016 00:39
Remove bower dependency for angular-file-upload
@lirantal
Copy link
Member

@hyperreality great work, thanks it looks good.

@lirantal lirantal merged commit 246c5d9 into meanjs:master Aug 26, 2016
@mleanos
Copy link
Member

mleanos commented Aug 29, 2016

Thank you @hyperreality! This looks really good! I just took it for a spin :)

@hyperreality
Copy link
Contributor Author

hyperreality commented Aug 29, 2016

@mleanos @lirantal Really appreciate all your recent work on the project too, and hope I can contribute more work from mine back into the main framework.

@lirantal
Copy link
Member

@hyperreality no problems. Looking forward to read more of your PRs with everyone else here :)

@simison
Copy link
Member

simison commented Sep 2, 2016

Ahh, hey, this PR should've not been merged with that ngImgCrop module. It's badly outdated and abandoned: alexk111/ngImgCrop#150

@hyperreality perhaps it would be easy to switch to ngImgCropFullExtended instead?

@lirantal @mleanos next time a bit more attention to healthiness of suggested packages. ;-)

@hyperreality
Copy link
Contributor Author

@simison Thanks for the heads up. ngImgCrop was being recommended and used by the author of ng-file-upload, so perhaps he needs a nudge too.

I've incorporated your suggestion into #1465

@simison
Copy link
Member

simison commented Sep 2, 2016

@hyperreality excellent!

@lirantal
Copy link
Member

lirantal commented Sep 2, 2016

Thanks @simison, I need more eyes and feedback on the frontend side PRs so will appreciate more help there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants