Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

fix(core): Update npm commands and documentation #1456

Merged
merged 1 commit into from
Aug 30, 2016

Conversation

simison
Copy link
Member

@simison simison commented Aug 27, 2016

Removes deprecated onlyChanged npm script. Watch now always runs only changed tests, no parameter needed.

Change to gulp tasks was in this commit: eaead7a

@simison
Copy link
Member Author

simison commented Aug 27, 2016

BTW I'm always a bit unsure how should I scope these fixes... "core", "npm", "build"?

@simison
Copy link
Member Author

simison commented Aug 28, 2016

Actually the whole thing should be called test:server:watch...

@lirantal
Copy link
Member

@simisonbuild is a good way to scope them.

@simison
Copy link
Member Author

simison commented Aug 28, 2016

Consider this still WIP, I'll add docs for this, too.

@mleanos
Copy link
Member

mleanos commented Aug 29, 2016

LGTM.

@simison simison changed the title fix(core): Remove onlyChanged npm script fix(core): Update npm commands and documentation Aug 30, 2016
@simison
Copy link
Member Author

simison commented Aug 30, 2016

Aight updated the documentation. How does it look to you now?

I basically wiped out mentions of Grunt and left Gulp there but everything directs towards npm commands. Preview README.md

I would've removed all the grunt modules and stuff, but I noticed it's still used for coverage tests... so perhaps that's a task for another PR. Edit: Seems like it's taken care of by @hyperreality : #1175 (comment)

- Removes deprecated `onlyChanged` npm script. Watch now always runs only changed tests, no parameter needed. Change to gulp tasks was in this commit: meanjs@eaead7a
- Renames npm script `test:watch` to `test:server:watch`
- Updates README.md to mention Gulp less and npm commands more
- Removes mentions to Grunt from README.md
@simison
Copy link
Member Author

simison commented Aug 30, 2016

(squashed + reflected updates at commit message)

@lirantal
Copy link
Member

Looks good, thanks.
P.S. you don't need to rebase and squash your commits, we can do it for you when we merge it in, just in case it's a bother for you.

@lirantal lirantal merged commit 64fd860 into meanjs:master Aug 30, 2016
@simison
Copy link
Member Author

simison commented Aug 30, 2016

👍

you don't need to rebase and squash your commits, we can do it for you when we merge it in, just in case it's a bother for you.

Yeah, I know. Just I wanted to rewrite the commit message.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants