This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
feat(users): change username to usernameOrEmail in signin #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simison
suggested changes
Oct 6, 2016
| $or: [{ | ||
| username: usernameOrEmail.toLowerCase() | ||
| }, { | ||
| email: usernameOrEmail |
There was a problem hiding this comment.
Emails are always saved lowercase in the db, so it's safe to set this usernameOrEmail.toLowerCase() as well. Otherwise I won't be able to login when writing e.g. "Fred@example.com".
|
We've been running pretty much identical signup controller for over a year now. Works great — no more "I forgot my username" support mails. |
|
Looks good, thanks @itelo ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite boring to force your users to remember the username they've created in your app to signin. So I've made an option to put an email or username. It's far more interesting to user experience, and a lot of applications are doing that, eg. Snapchat.