This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(express): Incorrest uses of 400 error codes #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes incorrest usage of 400 HTTP responses being returned from the server, in favor of using 422. Also, changed a few return codes to 401 where it was more appropriate. See this article for reasoning behind moving to 422, and why 400 isn't appropriate for these cases. For ref: meanjs@6be12f8 Related: meanjs#1547 meanjs#1510
|
In my haste to merge #1547, I forgot about the 400 error responses where we don't want to redirect the User. This resolves those issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect usage of 400 HTTP responses being returned from the server, in favor of using 422.
Also, changed a couple return codes to 401 where it was more appropriate.
See this article for reasoning behind moving to 422, and why 400 isn't appropriate for these cases.
https://www.bennadel.com/blog/2434-http-status-codes-for-invalid-data-400-vs-422.htm
Reference:
6be12f8
Related:
#1547
#1510