-
Notifications
You must be signed in to change notification settings - Fork 2k
Adds support for re-running server and client tests automatically #157
Conversation
@miguelcoba what about gulp? |
What's the status of this issue? Have the merge conflicts been resolved and the issue merged or...? |
@lirantal @NeverOddOrEven I think it's a good idea to have 2 separate tests, and just call them together in the |
I don't know what the merge conflicts could be, in August when I opened the bug and created the MR it merged without warnings. Also, in that time, only grunt was supported, that's why I only did the grunt test. I suppose that it would be easy to port it to gulp. |
@miguelcoba you have to rebase your changes off of the new master. Once you do that we'll be able to review it. |
@ilanbiala I agree, sounds like a nice idea. @miguelcoba it's impossible to merge this due to changes already commited on the same files you changed. |
I like this idea. |
@miguelcoba can you either rebase your changes so that we can merge this PR or open a new PR that will merge without conflicts? |
Adds two more tasks to execute server and client tests separately To run full suite grunt test To run only server tests grunt test:server To run only client tests grunt test:client Fixes #155
I did a rebase of pull request code to upstream/master code. This can be merged now to master. |
@miguelcoba looks good. @lirantal @NeverOddOrEven @roieki @amoshaviv I'll merge this if someone gives another +1. |
lgtm @ilanbiala, you can go ahead and merge. |
Adds support for re-running server and client tests automatically
Adds two more tasks to execute server and client tests separately
To run full suite
grunt test
To run only server tests
grunt test:server
To run only client tests
grunt test:client
Fixes #155