Developer Support - Warn when libs are not specified in config #171
Conversation
For purposes of dev support and sanity checking: - Added configurationChecks method to config object - Added a call to this method in server.js This could possibly be refactored out of config.js and into a module devoted to developer support methods.
NeverOddOrEven
changed the title
NeverOddOrEven
changed the title
|
@NeverOddOrEven you should switch this to Chalk. |
| // Get all the assets that have been loaded from NPM | ||
| var assetPathPresentInProject = this.getGlobbedFiles('./public/lib/*', './public/'); | ||
|
|
||
| console.info('\x1b[30m\x1b[47m'); |
There was a problem hiding this comment.
Use chalk to make the code cleaner.
|
@NeverOddOrEven I'm not sure I understand what are the configuration checks for exactly. What libs are supposed to be specified in all.js? |
|
This may not necessarily be relevant anymore. The support forum was seeing a lot of issues where people would add a dependency to their project, but not add it to all.js. I haven't seen that issue as much lately. This pull request would parse the all.js external files against those in the lib folder. Any top level library not in the all.js would be flagged and displayed with a warning. |
|
@NeverOddOrEven I think people are understanding the build and deployment process now, and I think it is less common. We can always revisit this later, but I think to keep the code simple and applicable to most people, we should leave it out unless the issues come up again. |
|
I don't disagree. Dev support can come into play later, as needed. |
There are numerous forum topics where developers are forgetting to update all.js. This is a diagnostic that runs when not in production, to assist developers.