This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Add some abstraction to local strategy login error #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rather say that the account doesn't exist, and then say that it's an invalid email or password if it does. |
|
From a user point of view, ofc it looks nicer to know in case if you did a mistake while logging in wether your username or password is wrong. However for a user with bad intentions this can be seen as a simple and effective way to prevent him from building a dataset with registered usernames. It's an option each developer can make. |
|
@lirantal thoughts? |
|
Looks ok |
ilanbiala
added a commit
that referenced
this pull request
Jun 3, 2015
Abstract the local strategy login error to thwart hackers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented in master but it is not in 0.4.0.
This basically prevents username enumeration by providing the same error message when the username doesn't exist or when the username/password combination is wrong.