This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Article middleware was calling getErrorMessage with a null argument #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt, causing a crash when this method tried to access 'code' on an null parameter. The bug was not exposed by the original test, since it was mixing two (related) aspects: * An invalid Id (a badly formed mongodb identifier) * An non-existent Id (an identifier with no corresponding document in the database) Modifications: - Fixed the message property in the article controller (the error message follows the wording of the error message in "users.password.server.controller.js", in case of username not found) - Added a new test to check modifications and avoid regressions
This was referenced Jul 28, 2015
|
@lirantal LGTM. |
|
Thanks guys. |
lirantal
added a commit
that referenced
this pull request
Jul 29, 2015
Article middleware was calling getErrorMessage with a null argument
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The article middleware was calling getErrorMessage with a null argument, causing a crash when this method tried to access 'code' on an null parameter.
The bug was not exposed by the original test, since it was mixing two (related) aspects:
Modifications: