fixing jshint single quotes issues #904
Conversation
| @@ -12,6 +12,7 @@ | |||
| "undef": true, // Require all non-global variables be declared before they are used. | |||
| "unused": false, // Warn unused variables. | |||
| "strict": true, // Require `use strict` pragma in every file. | |||
| "quotmark": "single", // Require only single quotes | |||
There was a problem hiding this comment.
@lirantal and @ilanbiala , can we keep quotmark in here until #763 is addressed? Reason being is that I missed a lot of the double quote issues in my last PR.
There was a problem hiding this comment.
@jloveland I don't think it's really that necessary to just make a temporary commit..I'd rather wait a few days for ESLint.
jloveland
force-pushed
the
jshint-single-quotes
branch
from
7f77e3b
to
a38abd0
Compare
|
Thanks @jloveland |
|
@lirantal, without |
jloveland
changed the title
|
Yes, whenever @rhutchison will move forward with that ESLint PR... |
|
Since we are embracing the single quotes all around the project then this PR LGTM, and once we have linting for code styles then this will be enforced too. @ilanbiala do you have any other thoughts about this? |
| { color: "info", progress: "60"}, | ||
| { color: "primary", progress: "80"}, | ||
| { color: "success", progress: "100"} | ||
| { color: 'danger', progress: '20' }, |
There was a problem hiding this comment.
consistent spacing in this array of objects please
|
Nope, LGTM. |
|
@ilanbiala I fixed spacing |
|
@jloveland we are going to add ESLint, so no need to add it back. |
|
@ilanbiala looks like we're delaying quite a bit with the ESLint PR so I recommend if we don't get that PR in the next few days from @rhutchison then let's just create it ourself. It is much more important now that every PR needs to conform to some kind of style. |
|
@lirantal I know @rhutchison has started on it. But hasn't been touched in a little bit. |
|
I remember we already have some issue which discusses code formatting but if we don't lets open one and put everything there for a discussion. I'll merge this one in. |
fixing jshint single quotes issues
fixing jshint issues by requiring single quotes