This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Add .eslintrc #989
Closed
Add .eslintrc #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I added Grunt and Gulp support, which means that we now get errors in our builds. The question is whether we want that to fail our builds (which I think should be the case). If so, I suggest we devote another PR to fixing those issues and make this PR strictly for adding in ESLint. |
|
Yes it should fail the build and we should submit PR's to fix the entire project. |
|
@ilanbiala I think it should fail the build. However, do we want to fix the issues before we force it to fail? I'd hate for this to get merged in and have every PR after this fail because of eslint errors in other parts of the code. |
|
👍 On fixing the issues in separate PR(s) before this gets merged. |
|
Agree with the above. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763
@lirantal @codydaig @rhutchison