Upgrade react/next version #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixing... |
|
Coverage after merging update/react-next into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging update/react-next into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
JinTakenaka
commented
Nov 22, 2022
| "webpack": "^5.75.0" | ||
| }, | ||
| "resolutions": { | ||
| "react-test-renderer": "18.2.0" |
There was a problem hiding this comment.
どうにも現状ではreact18でstorybookを動作させるにはreact-test-rendererのバージョンを強制的に指定する必要がある模様
|
Coverage after merging update/react-next into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging update/react-next into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
|
Coverage after merging update/react-next into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
JinTakenaka
commented
Nov 22, 2022
| "lint-staged": "^12.4.1", | ||
| "nock": "^13.2.7", | ||
| "prettier": "^2.6.2", | ||
| "sass": "^1.52.3", | ||
| "sass-loader": "^13.0.0", | ||
| "storybook-addon-next-router": "^4.0.0", | ||
| "next-router-mock": "^0.8.0", |
There was a problem hiding this comment.
next13でnext/routerをインポートすると
you should only use "next/router" on the client side of your app.
と言われていしまうので、その対策として導入
|
Coverage after merging update/react-next into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
|
Coverage after merging update/react-next into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
JinTakenaka
changed the title
JinTakenaka
commented
Nov 22, 2022
| @@ -17,6 +17,7 @@ Array [ | |||
| href="/login" | |||
| onClick={[Function]} | |||
| onMouseEnter={[Function]} | |||
| onTouchStart={[Function]} | |||
There was a problem hiding this comment.
（おそらく）React18の影響？
JinTakenaka
commented
Nov 22, 2022
| import { renderHook, act, RenderResult } from '@testing-library/react-hooks' | ||
|
|
||
| import { useCSR } from '../useCSR' | ||
|
|
||
| jest.mock('next/router') | ||
| jest.mock('next/router', () => require('next-router-mock')) |
There was a problem hiding this comment.
これで
you should only use "next/router" on the client side of your app.
と言われない
There was a problem hiding this comment.
細かいですが、jest.mockはimportの後の行に書きましょう。
記載自体は問題ないです。
MasahikoJinno
approved these changes
Nov 24, 2022
|
Coverage after merging update/react-next into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update next version to 13
update react version to 18