Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the jax example #146

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Conversation

jhelgert
Copy link
Contributor

@jhelgert jhelgert commented Feb 3, 2022

Fixes #144 and #145 .

@moorepants
Copy link
Collaborator

The tests fail on macosx only with python 3.9, giving:

Installed /usr/local/miniconda/envs/test-environment/lib/python3.9/site-packages/cyipopt-1.2.0.dev0-py3.9-macosx-10.9-x86_64.egg
Processing dependencies for cyipopt==1.2.0.dev0
Searching for cyipopt==1.2.0.dev0
Reading https://pypi.org/simple/cyipopt/
/usr/local/miniconda/envs/test-environment/lib/python3.9/site-packages/pkg_resources/__init__.py:122: PkgResourcesDeprecationWarning:  is an invalid version and will not be supported in a future release
  warnings.warn(
No local packages or working download links found for cyipopt==1.2.0.dev0
error: Could not find suitable distribution for Requirement.parse('cyipopt==1.2.0.dev0')
Error: Process completed with exit code 1.

@moorepants
Copy link
Collaborator

This issue only being on Python 3.9 and Mac is odd:

Processing dependencies for cyipopt==1.2.0.dev0
Searching for cyipopt==1.2.0.dev0
Reading https://pypi.org/simple/cyipopt/
/usr/local/miniconda/envs/test-environment/lib/python3.9/site-packages/pkg_resources/__init__.py:122: PkgResourcesDeprecationWarning:  is an invalid version and will not be supported in a future release
  warnings.warn(
No local packages or working download links found for cyipopt==1.2.0.dev0
error: Could not find suitable distribution for Requirement.parse('cyipopt==1.2.0.dev0')
Error: Process completed with exit code 1.

It is like it is searching pypi for a cyipopt==1.20.dev0 to download. Not quite sure why it would be doing that. It thinks cyipopt is a dependency of itself.

@brocksam
Copy link
Collaborator

Our CI workflows is using python setup.py install to install CyIpopt. I think this is a hangover from distutils and might now be deprecated. I wonder if using pip install . instead might fix the weird macOS-only bug?

@moorepants
Copy link
Collaborator

Oh me, if they remove setup.py that's going to bring back Py2->Py3-like pains.

We can try the pip command instead for this.

@moorepants
Copy link
Collaborator

@jhelgert Can you merge in master to get this #149?

@jhelgert
Copy link
Contributor Author

@moorepants Done.

@moorepants
Copy link
Collaborator

LGTM!

Thanks :)

@moorepants moorepants merged commit 5e371be into mechmotum:master Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve the example "hs071_scipy_jax.py"
3 participants