Add sanity checks to Jacobian / Hessian indices #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some unit tests for these error messages? |
chrhansk
force-pushed
the
master
branch
2 times, most recently
from
0626939 to
8a5bc80
Compare
|
I added tests for the Hessian. There is apparently a problem with the error handling in Ipopt itself (see coin-or/Ipopt/pull/697) which so far prevents error messages from the Jacobian evaluation being handled within Ipopt. |
|
Edit: coin-or/Ipopt#697 has been merged, so the bug in Ipopt should be fixed starting from version |
|
Thanks for this contribution. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the indices are not correct, then ipopt seems to segfault, so the errors should be caught earlier in the interface.