Resolve compatibility issues with windows

[apommel]

Attempt at resolving both setup compatibility problems with windows #45 #46 for the latest Ipopt dll build available (3.11.0) and windows import issues #21

[moorepants]

There are some Travis errors with these changes:

The command "python setup.py install" exited with 0.

0.03s$ python -c "import ipopt"

Traceback (most recent call last):

  File "<string>", line 1, in <module>

  File "/home/travis/build/matthias-k/cyipopt/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python -c "import ipopt"" exited with 1.

0.17s$ python test/examplehs071.py

Traceback (most recent call last):

  File "test/examplehs071.py", line 25, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/examplehs071.py" exited with 1.

0.18s$ python test/exception_handling.py

Traceback (most recent call last):

  File "test/exception_handling.py", line 23, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/exception_handling.py" exited with 1.

0.18s$ python test/lasso.py

Traceback (most recent call last):

  File "test/lasso.py", line 32, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/lasso.py" exited with 1.

[victoraalves]

It appears to be working on Windows 10 64 bits - v

There are some Travis errors with these changes:

The command "python setup.py install" exited with 0.

0.03s$ python -c "import ipopt"

Traceback (most recent call last):

  File "<string>", line 1, in <module>

  File "/home/travis/build/matthias-k/cyipopt/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python -c "import ipopt"" exited with 1.

0.17s$ python test/examplehs071.py

Traceback (most recent call last):

  File "test/examplehs071.py", line 25, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/examplehs071.py" exited with 1.

0.18s$ python test/exception_handling.py

Traceback (most recent call last):

  File "test/exception_handling.py", line 23, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/exception_handling.py" exited with 1.

0.18s$ python test/lasso.py

Traceback (most recent call last):

  File "test/lasso.py", line 32, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/lasso.py" exited with 1.

Followed the instructions and it appears to be finally working under Windows 10 (tested on 64bits version 1909, build 18363.476).
Note 1 : I had to install visual studio build tools.
Note 2: Used the same version of pre-compiled IPOPT (3.11.0) from COIN-OR website that apommel did and "setup.py" worked fine.

[apommel]

@moorepants Yep I saw that. It does exactly the opposite of what it did on windows before. I don't really know linux so I am not sure, but I would expect both of them to behave similarly on imports. I will try to find something that works on both systems.
Also I am using python 3.7, maybe it has an influence ? I don't think so though.

[victoraalves]

It appears to be working on Windows 10 64 bits - v

There are some Travis errors with these changes:

The command "python setup.py install" exited with 0.

0.03s$ python -c "import ipopt"

Traceback (most recent call last):

  File "<string>", line 1, in <module>

  File "/home/travis/build/matthias-k/cyipopt/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python -c "import ipopt"" exited with 1.

0.17s$ python test/examplehs071.py

Traceback (most recent call last):

  File "test/examplehs071.py", line 25, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/examplehs071.py" exited with 1.

0.18s$ python test/exception_handling.py

Traceback (most recent call last):

  File "test/exception_handling.py", line 23, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/exception_handling.py" exited with 1.

0.18s$ python test/lasso.py

Traceback (most recent call last):

  File "test/lasso.py", line 32, in <module>

    import ipopt

  File "/home/travis/miniconda/envs/test-env/lib/python3.6/site-packages/ipopt-0.2.0.dev0-py3.6-linux-x86_64.egg/ipopt/__init__.py", line 43, in <module>

    from .cyipopt import *

ModuleNotFoundError: No module named 'ipopt.cyipopt'

The command "python test/lasso.py" exited with 1.

Followed the instructions and it appears to be finally working under Windows 10 (tested on 64bits version 1909, build 18363.476).
Note 1 : I had to install visual studio build tools.
Note 2: Used the same version of pre-compiled IPOPT (3.11.0) from COIN-OR website that apommel did and "setup.py" worked fine.

[victoraalves]

Attempt at resolving both setup compatibility problems with windows #45 #46 for the latest Ipopt dll build available (3.11.0) and windows import issues #21

Thank you. At least for me, it solved the problem.

[apommel]

I tried something, the build structure seemed somehow different between linux and windows setup, so I tried to harmonize that. Because I don't have access to a linux system I couldn't test the commit beforehand so the travis builds still seem to fail at some point but the tests seem to execute correctly though.

I can also edit the windows structure to be similar to linux and it should pass, but somehow I feel like the windows structure makes more sense. I saw that it was planned to rename the main module cyipopt, so I think a more proper and general fix could be done at this moment.

[apommel]

I changed the setup structure for windows instead of linux this time and reverted the other changes. This way, the checks pass and it also works on windows (for me at least) with only minor modifications compared to the current implementation.
I still think cyipopt is better as a subpackage of ipopt than a separate package though, or ultimately with cyipopt being the name of the package and ipopt the name of the subpackage.

[feslima]

@apommel I definitely agree with cyipopt being the name of the package. I'm having issues when packaging a module with this package as dependency (because the conda-forge channel already has a package named ipopt).

I would appreciate if this naming issue could be solved or if you have any idea/tips on how to solve this.

[moorepants]

The naming is the result of how Cython works. The discussion for changing the distribution and/or package names should be handled in another issue. Note that it has been discussed in #14.

[moorepants]

Do you know what version of IPOPT made these changes? It could be helpful to add that we only support ipopt >= some version for windows in the README.

[apommel]

From the official builds available here, the directory is organized this way starting Ipopt 3.10.1.

[moorepants]

Can you note this in the README? i.e. that for Windows we only support Ipopt >= 3.10.1.

[apommel]

Added in latest commit.

[apommel]

The naming is the result of how Cython works. The discussion for changing the distribution and/or package names should be handled in another issue. Note that it has been discussed in #14.

I have seen this issue, that is why I mentioned that this should be better looked at at this time. For this PR, assuring compatibility with windows while keeping the current implementation is enough I think.

[moorepants]

@apommel Thanks for the changes. I'm going to merge this, but I'd like to get a windows CI setup to test this, before a new release happens.