Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add java_multiple_files option in proto files #168

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Jul 8, 2021

Simply added setting java_multiple_files = true; to proto file.

@gyuguen gyuguen requested a review from cl9200 as a code owner July 8, 2021 02:36
@gyuguen gyuguen linked an issue Jul 8, 2021 that may be closed by this pull request
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can merge this PR first before I merge #166 . I have something to experiment in that PR.

@gyuguen
Copy link
Contributor Author

gyuguen commented Jul 8, 2021

@youngjoon-lee
OKay. Let's merge this first.

@gyuguen gyuguen merged commit 59c47cd into master Jul 8, 2021
@gyuguen gyuguen deleted the feat/167/add-java_multiple_option-proto branch July 8, 2021 02:43
@youngjoon-lee youngjoon-lee added this to the v2.0.0 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'java_multiple_files' to options in proto files.
2 participants