fix: Use the protobuf oneof keyword for VerificationRelationship
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuguen
reviewed
Jul 8, 2021
gyuguen
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VerificationRelationshipis a good place to use the protobuf oneof keyword, because it contains either a string or aVerificationMethod.The current definition is old-fashioned that I implemented in Panacea v1.3.
The
oneofis much more intuitive and much easier for client developers.We don't need to worry about JSON <-> Protobuf, because we've already been relying on
gogoproto.customtype.Initially, I tried to remove the
gogoproto.customtype, but the default behavior ofjsonpbdoesn't handleoneofstuff the way we want.So, let's keep
gogoproto.customtype. There's no choice in order to obey the W3C spec.