Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add validation for MsgCreateDeal #254

Merged
merged 2 commits into from
Jan 17, 2022
Merged

fix: Add validation for MsgCreateDeal #254

merged 2 commits into from
Jan 17, 2022

Conversation

inchori
Copy link

@inchori inchori commented Jan 17, 2022

  • Rename target_num_data and filled_num_data to max_num_data and cur_num_data.
  • Validation for MsgCreateDeal in tx.proto file and ValidateBasic() function in message_deal.go file.
  • Remove NextDealNumber field in ExportGenesis function.

TODO

  • Implement GetDealsList for ExportGenesis.
  • Test Code for client command-line txDeal.go.

gyuguen
gyuguen approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

youngjoon-lee
youngjoon-lee approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@inchori inchori merged commit 7f1d793 into ft/na/market/create-deal Jan 17, 2022
@inchori inchori deleted the ft/na/market/create-deal-2 branch January 17, 2022 06:59
@youngjoon-lee youngjoon-lee added this to the Marketplace M1 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200

@0xHansLee 0xHansLee Awaiting requested review from 0xHansLee

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
Data Deal Model
Development

Successfully merging this pull request may close these issues.
3 participants
@inchori @youngjoon-lee @gyuguen