Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Redefine connection method and data type of some fields #261

Merged
merged 1 commit into from
Jan 28, 2022
Merged

fix: Redefine connection method and data type of some fields #261

merged 1 commit into from
Jan 28, 2022

Conversation

inchori
Copy link

@inchori inchori commented Jan 27, 2022 •
edited
Loading

Redefine connection method and data type of some fields as @gyuguen said.

JSON

  • Change the fields data_hash, encrypted_data_url, and signaturein UnsignedDataValidationCertificate to string in parse.go.
  • Add the suffix _base64 to the fields.

Proto

  • Change the fields data_hash, encrypted_data_url, in UnsignedDataValidationCertificate to string in tx.proto.

@inchori inchori self-assigned this Jan 27, 2022
@inchori inchori added this to the DataMarket M1 milestone Jan 27, 2022
@inchori inchori changed the title fix: Fix data type of some fields fix: Redefine connection method and data type of some fields Jan 27, 2022
0xHansLee
0xHansLee approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

gyuguen
gyuguen approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@inchori inchori merged commit fffdcf8 into ft/na/market/sell-data Jan 28, 2022
@inchori inchori deleted the ft/na/market/sell-data-datatype branch January 28, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200

@youngjoon-lee youngjoon-lee Awaiting requested review from youngjoon-lee

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
Data Deal Model
Development

Successfully merging this pull request may close these issues.
3 participants
@inchori @gyuguen @0xHansLee