feat: skeleton for x/datapool and proto files
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 21, 2022 12:36
…3/skeleton # Conflicts: # go.mod # go.sum
0xHansLee
requested review from
cl9200,
youngjoon-lee and
gyuguen
as code owners
proto/panacea/datapool/v2/pool.proto
Outdated
| uint64 target_num_data = 4; // target number of data | ||
| uint64 cur_num_data = 5; // current number of data | ||
| uint64 max_nft_supply = 6; // max supply of data access NFT of the pool | ||
| uint64 issued_nft = 7; // current issued NFT |
There was a problem hiding this comment.
Does this issued_nft means the curation NFT ID? or the number of NFTs issued?
There was a problem hiding this comment.
The latter. It would be better to use num_issued_nft to make clearer. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x/datapoolhave been made via starport.