Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Command Line for Register Data Validator #286

Merged
merged 1 commit into from
Mar 24, 2022
Merged

feat: Command Line for Register Data Validator #286

merged 1 commit into from
Mar 24, 2022

Conversation

inchori
Copy link

@inchori inchori commented Mar 24, 2022

  • Command-Line Interface(CLI) for Register Data Validator.
  • Add CmdRegisterDataValidator and modify ValidateBasic function.

@inchori inchori requested a review from 0xHansLee March 24, 2022 06:11
@inchori inchori added the Market Data Marketplace for Web3.0 label Mar 24, 2022
@inchori inchori linked an issue Mar 24, 2022 that may be closed by this pull request
Implement the MsgRegisterDataValidator transaction #274
Closed
@inchori inchori self-assigned this Mar 24, 2022
gyuguen
gyuguen approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

0xHansLee
0xHansLee approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inchori inchori merged commit 7b16161 into ft/274/register_data_validator_tx Mar 24, 2022
@inchori inchori deleted the ft/274/register_data_validator_tx_cmd branch March 24, 2022 07:36
@inchori inchori added this to the Data Pool Model milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200

@youngjoon-lee youngjoon-lee Awaiting requested review from youngjoon-lee

Assignees

@inchori inchori

Labels
Market Data Marketplace for Web3.0
Projects
None yet
Milestone
Data Pool Model
Development

Successfully merging this pull request may close these issues.

Implement the MsgRegisterDataValidator transaction
3 participants
@inchori @gyuguen @0xHansLee