Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Registered Data Validator #296

Merged
merged 4 commits into from
Apr 6, 2022
Merged

feat: Update Registered Data Validator #296

merged 4 commits into from
Apr 6, 2022

Conversation

inchori
Copy link

@inchori inchori commented Apr 4, 2022

  • Update (or Edit) Registered Data Validator.
  • Data Validator can change their endpoint URL as @youngjoon-lee said.
  • Implement keeper and client.

@inchori inchori requested a review from 0xHansLee April 4, 2022 05:55
@inchori inchori self-assigned this Apr 4, 2022
@inchori inchori added the Market Data Marketplace for Web3.0 label Apr 4, 2022
@inchori inchori added this to the Data Pool Model milestone Apr 4, 2022
gyuguen
gyuguen approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

youngjoon-lee
youngjoon-lee approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gyuguen
gyuguen approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@inchori inchori merged commit d5af49b into master Apr 6, 2022
@inchori inchori deleted the ft/datapool/update-data-validator branch April 6, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

@0xHansLee 0xHansLee Awaiting requested review from 0xHansLee

Assignees

@inchori inchori

Labels
Market Data Marketplace for Web3.0
Projects
None yet
Milestone
Data Pool Model
Development

Successfully merging this pull request may close these issues.
4 participants
@inchori @youngjoon-lee @gyuguen @0xHansLee