Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added query pool #297

Merged
merged 4 commits into from
Apr 5, 2022
Merged

feat: added query pool #297

merged 4 commits into from
Apr 5, 2022

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Apr 4, 2022

Added a function to query the pool.

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

How about we add query pool test in grpc_query_pool_test.go too?

Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyuguen
Copy link
Contributor Author

gyuguen commented Apr 4, 2022

LGTM 👍

How about we add query pool test in grpc_query_pool_test.go too?

Great. I'll add it

Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuguen gyuguen merged commit 3f37140 into master Apr 5, 2022
@gyuguen gyuguen deleted the ft/47/query_datapool branch April 5, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants