refactor: add deposit rate #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2022 13:10
0xHansLee
requested review from
cl9200,
youngjoon-lee,
gyuguen and
inchori
as code owners
added 2 commits
April 25, 2022 11:07
…t-spec # Conflicts: # x/datapool/client/cli/txPool.go # x/datapool/keeper/pool_test.go # x/datapool/types/genesis.pb.go # x/datapool/types/tx.pb.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously have
data_pool_deposit, which is a fixed value of deposit for creation data pool.In this PR, it is changed to
data_pool_deposit_rateas a governance parameter, which is proportional to the expected total sales of data pass. (0 <=data_pool_deposit_rate<= 1)required_deposit= (total_supply_data_pass*price_data_pass) *deposit_rateAccordingly, check is added whether the deposit curator sent is greater than or equal to the required deposit.
Plus, the deposit field is added to pool, (refer the comment)