feat: add data pass redeem history query #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xHansLee
requested review from
cl9200,
youngjoon-lee,
gyuguen and
inchori
as code owners
0xHansLee
commented
May 23, 2022
0xHansLee
commented
May 23, 2022
gyuguen
approved these changes
May 24, 2022
added 2 commits
May 25, 2022 14:35
…s-addr # Conflicts: # x/datapool/types/pool.pb.go # x/datapool/types/query.pb.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current kv store of redeem receipts, we cannot retrieve data pass redeem receipts by redeemer's address. Because the key is composed of poolID, round, and nftID, not redeemer's address.
With the need of getting receipts by redeemer's address in data validator, I made another kv store that the key is composed of redeemer's address and poolID. When redeemer redeems data pass, the redeem history is also stored/updated (
k.appendDataPassRedeemHistory()).I implemented a query of the redeem history by redeemer's address and pool ID as well.
What I've done