Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: shortening the name DataValidationCertificate to DataCert #340

Merged
merged 5 commits into from
Jun 2, 2022

Conversation

0xHansLee
Copy link
Contributor

As mentioned in previous PR, DataValidationCertificate is renamed to DataCert
Plus, all the certificate have been shortened to cert

Closes #339

hansol-medi added 5 commits June 2, 2022 14:32
# Conflicts:
#	proto/panacea/datapool/v2/pool.proto
#	x/datadeal/client/cli/txDeal_test.go
#	x/datadeal/genesis_test.go
#	x/datadeal/keeper/deal.go
#	x/datadeal/keeper/deal_test.go
#	x/datadeal/keeper/msg_server_deal.go
#	x/datadeal/types/tx.pb.go
#	x/datapool/keeper/grpc_query_pool_test.go
#	x/datapool/keeper/pool.go
#	x/datapool/keeper/pool_test.go
#	x/datapool/types/errors.go
#	x/datapool/types/pool.pb.go
#	x/datapool/types/query.pb.go
#	x/datapool/types/tx.pb.go
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danke

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@0xHansLee 0xHansLee merged commit 824b9bc into master Jun 2, 2022
@0xHansLee 0xHansLee deleted the ft/339/rename-data-cert branch June 2, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorten the name of DataValidationCertificate to DataCert
3 participants