Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement register oracle #519

Merged
merged 8 commits into from
Dec 8, 2022
Merged

feat: implement register oracle #519

merged 8 commits into from
Dec 8, 2022

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Dec 6, 2022

Closes #509

Implement

  • Added Keeper and CLI for oracle registration
  • Added oracleRegistration's event

I will add Oracle's genesis process the next PR.

@gyuguen gyuguen added this to the v2.1.0-beta milestone Dec 6, 2022
@gyuguen gyuguen self-assigned this Dec 6, 2022
@gyuguen gyuguen marked this pull request as draft December 6, 2022 04:59
@gyuguen gyuguen force-pushed the ft/509/implement_register_oracle branch from b3a30fb to 2c97872 Compare December 6, 2022 05:36
@gyuguen gyuguen changed the base branch from ft/510/approve_oracle_registration_keeper to main December 6, 2022 05:42
@gyuguen gyuguen changed the base branch from main to ft/510/approve_oracle_registration_keeper December 6, 2022 05:49
@gyuguen gyuguen force-pushed the ft/509/implement_register_oracle branch from 2c97872 to 454a4d1 Compare December 6, 2022 06:02
@gyuguen gyuguen changed the base branch from ft/510/approve_oracle_registration_keeper to main December 6, 2022 06:02
@gyuguen gyuguen marked this pull request as ready for review December 6, 2022 06:03
0xHansLee
0xHansLee approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work.
I left minor comments ragarding ValidateBasic().
If you are gonna handle those things later (because it is relevant to other message, not RegisterOracle), you can ignore this comments

x/oracle/types/oracle.go Outdated Show resolved Hide resolved
x/oracle/types/message_oracle.go Show resolved Hide resolved
x/oracle/types/message_oracle.go Show resolved Hide resolved
x/oracle/types/message_oracle.go Show resolved Hide resolved
audtlr24
audtlr24 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@gyuguen
Copy link
Contributor Author

gyuguen commented Dec 7, 2022

@H4NLee
Thank you!
I fixed it (c85605d)

inchori
inchori approved these changes Dec 7, 2022
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@audtlr24 audtlr24 mentioned this pull request Dec 7, 2022
Merged
youngjoon-lee
youngjoon-lee approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuguen gyuguen merged commit 7b370d5 into main Dec 8, 2022
@gyuguen gyuguen deleted the ft/509/implement_register_oracle branch December 8, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@gyuguen gyuguen

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Implement RegisterOracle tx
5 participants
@gyuguen @youngjoon-lee @audtlr24 @0xHansLee @inchori