Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skeleton code for datadeal module #520

Merged
merged 7 commits into from
Dec 7, 2022
Merged

feat: add skeleton code for datadeal module #520

merged 7 commits into from
Dec 7, 2022

Conversation

inchori
Copy link

@inchori inchori commented Dec 6, 2022

Add skeleton code for x/datadeal.

@inchori inchori added this to the v2.1.0-beta milestone Dec 6, 2022
@inchori inchori self-assigned this Dec 6, 2022
@inchori inchori requested a review from gyuguen as a code owner December 6, 2022 06:17
@inchori inchori removed the x/datadeal label Dec 6, 2022
0xHansLee
0xHansLee reviewed Dec 6, 2022
View reviewed changes
x/datadeal/genesis.go Outdated Show resolved Hide resolved
audtlr24
audtlr24 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0xHansLee
0xHansLee approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gyuguen
gyuguen approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left an one comment.

x/datadeal/types/message_deal.go Outdated Show resolved Hide resolved
@inchori inchori mentioned this pull request Dec 7, 2022
Merged
@inchori inchori merged commit ac668d4 into main Dec 7, 2022
@inchori inchori deleted the ft/na/skeleton_code_datadeal branch December 7, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuguen gyuguen gyuguen approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

@youngjoon-lee youngjoon-lee Awaiting requested review from youngjoon-lee

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.
4 participants
@inchori @gyuguen @audtlr24 @0xHansLee