Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add encrypt-data CLI #529

Merged
merged 11 commits into from
Dec 12, 2022
Merged

feat: Add encrypt-data CLI #529

merged 11 commits into from
Dec 12, 2022

Conversation

0xHansLee
Copy link
Contributor

close #524

Based on #523, encrypt-data CLI has been implemented because query of oracle module params is needed.

@0xHansLee 0xHansLee added this to the v2.1.0-beta milestone Dec 7, 2022
@0xHansLee 0xHansLee self-assigned this Dec 7, 2022
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from ft/na/add_oracles_query_cli to main December 8, 2022 01:17
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)
I have an one question.

And I can see my PR content :)

cmd/panacead/cmd/encrypt_data.go Outdated Show resolved Hide resolved
H4NLee and others added 5 commits December 8, 2022 13:44
# Conflicts:
#	proto/panacea/oracle/v2/tx.proto
#	x/oracle/client/cli/query.go
#	x/oracle/client/cli/txRegisterOracle.go
#	x/oracle/genesis.go
#	x/oracle/keeper/grpc_query_oracle.go
#	x/oracle/keeper/grpc_query_oracle_test.go
#	x/oracle/keeper/oracle.go
#	x/oracle/keeper/oracle_test.go
#	x/oracle/types/message_oracle.go
#	x/oracle/types/oracle.go
#	x/oracle/types/query.pb.go
#	x/oracle/types/tx.pb.go
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuguen gyuguen linked an issue Dec 9, 2022 that may be closed by this pull request
@0xHansLee 0xHansLee merged commit 82c9400 into main Dec 12, 2022
@0xHansLee 0xHansLee deleted the ft/524/encrypt-cli branch December 12, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI: Encrypt
5 participants