Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add UpdateOracleInfo tx #540

Merged
merged 17 commits into from
Dec 14, 2022
Merged

feat: add UpdateOracleInfo tx #540

merged 17 commits into from
Dec 14, 2022

Conversation

audtlr24
Copy link
Contributor

@audtlr24 audtlr24 commented Dec 8, 2022

closes #511.

  • add oracle_commission_max_rate and oracle_commission_max_change_rate
  • check commission change (max_rate, max_change_rate, updateTime)
  • change RegisterOracle and related code to include that commission part

@audtlr24 audtlr24 added this to the v2.1.0-beta milestone Dec 8, 2022
@audtlr24 audtlr24 requested a review from cl9200 as a code owner December 8, 2022 07:18
@audtlr24 audtlr24 self-assigned this Dec 8, 2022
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
Please check my comment.

x/oracle/client/cli/txRegisterOracle.go Outdated Show resolved Hide resolved
x/oracle/client/cli/txUpdateOracleInfo.go Outdated Show resolved Hide resolved
x/oracle/keeper/oracle.go Outdated Show resolved Hide resolved
x/oracle/keeper/oracle_test.go Show resolved Hide resolved
x/oracle/types/message_oracle.go Outdated Show resolved Hide resolved
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Thx!

x/oracle/client/cli/txRegisterOracle.go Outdated Show resolved Hide resolved
x/oracle/client/cli/txRegisterOracle.go Outdated Show resolved Hide resolved
x/oracle/client/cli/txRegisterOracle.go Outdated Show resolved Hide resolved
x/oracle/client/cli/txUpdateOracleInfo.go Outdated Show resolved Hide resolved
x/oracle/client/cli/txUpdateOracleInfo.go Show resolved Hide resolved
x/oracle/keeper/msg_server_oracle.go Outdated Show resolved Hide resolved
x/oracle/keeper/oracle.go Outdated Show resolved Hide resolved
x/oracle/keeper/oracle.go Outdated Show resolved Hide resolved
x/oracle/keeper/oracle.go Outdated Show resolved Hide resolved
…info

# Conflicts:
#	x/oracle/handler.go
#	x/oracle/keeper/oracle.go
#	x/oracle/keeper/oracle_test.go
#	x/oracle/types/errors.go
…info

# Conflicts:
#	proto/panacea/oracle/v2/oracle.proto
#	x/oracle/keeper/grpc_query_oracle_test.go
#	x/oracle/types/oracle.pb.go
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I left minor comments.

x/oracle/client/cli/txUpdateOracleInfo.go Show resolved Hide resolved
x/oracle/types/errors.go Outdated Show resolved Hide resolved
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@audtlr24 audtlr24 merged commit c9bab83 into main Dec 14, 2022
@audtlr24 audtlr24 deleted the ft/511/update_oracle_info branch December 14, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement UpdateOracleInfo tx
5 participants