Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DeactivateDeal Tx keeper, and CLI #543

Merged
merged 8 commits into from
Dec 12, 2022

Conversation

inchori
Copy link

@inchori inchori commented Dec 9, 2022

Closes #530

The branch name includes a keeper, but I just implemented cmd part, too. Because, this feature is not big as I thought.

@inchori inchori added this to the v2.1.0-beta milestone Dec 9, 2022
@inchori inchori self-assigned this Dec 9, 2022
@inchori inchori marked this pull request as draft December 9, 2022 08:11
@inchori inchori marked this pull request as ready for review December 9, 2022 08:33
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left minor suggestion.

x/datadeal/types/message_deal.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/datadeal/keeper/deal.go Outdated Show resolved Hide resolved
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inchori inchori merged commit 4702ce2 into main Dec 12, 2022
@inchori inchori deleted the ft/530/deactivate_deal_keeper branch December 12, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DeactivateDeal tx
5 participants