feat: add agreement_terms field in the datadeal
#618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjoon-lee
requested review from
gyuguen,
0xHansLee,
inchori and
audtlr24
as code owners
youngjoon-lee
changed the title
agreement_terms field in the datadeal
youngjoon-lee
changed the title
agreement_terms field in the datadealagreement_terms field in the datadeal
youngjoon-lee
commented
Jan 11, 2023
Comment on lines
-70
to
-73
| if m.Consent.Certificate == nil { | ||
| return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "certificate is empty") | ||
| } | ||
|
|
There was a problem hiding this comment.
This code block has been moved into the Conset.ValidateBasic().
https://github.com/medibloc/panacea-core/pull/618/files#diff-96ca4563a066ba12d7027c1dfae0f3379db834ade078b47a86b8bd6000ace671R9
youngjoon-lee
changed the title
agreement_terms field in the datadealagreement_terms field in the datadeal
youngjoon-lee
deleted the
602-add-agreement_terms-field-in-the-datadeal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #602
Review Guide
*_test.go).DealandConsentformat to the existing tests.