Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/token: Fix to update the total supply of all coins when issuing new tokens #95

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Mar 31, 2021

Fixes #93

No unit test yet. Unit tests will be added soon by following the Cosmos-SDK's way (probably in the newer Cosmos version).

A manual test was done:

panacead export --for-zero-height --height=10
    "supply": {
      "supply": [
        {
          "amount": "1000000000",
          "denom": "ulov221"
        },
        {
          "amount": "100000001584400",
          "denom": "umed"
        }
      ]
    },
    "token": {
      "tokens": {
        "LOV-221": {
          "mintable": false,
          "name": "love",
          "owner_address": "panacea1xs5e3p3jxfxr3n9xluagkgnxxk9vpcm0dcrew2",
          "symbol": "LOV-221",
          "total_supply": {
            "amount": "1000000000",
            "denom": "ulov221"
          }
        }
      }
    }

Copy link
Contributor

@cl9200 cl9200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngjoon-lee youngjoon-lee merged commit 2ef8a19 into master Apr 7, 2021
@youngjoon-lee youngjoon-lee deleted the fix/93/token-total-supply branch April 7, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/token: Total supply is not updated
2 participants