Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JWT authentication (without nonce) #19

Merged
merged 15 commits into from
Dec 8, 2022
Merged

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Dec 7, 2022

Closes #8

For unit tests with mocking, I changed QueryClient as interface.

H4NLee and others added 4 commits December 6, 2022 16:55
@youngjoon-lee youngjoon-lee added this to the v2.1.0-beta milestone Dec 7, 2022
@youngjoon-lee youngjoon-lee self-assigned this Dec 7, 2022
@youngjoon-lee youngjoon-lee changed the title feat: add JWT authentication feat: add JWT authentication (without nonce) Dec 7, 2022
@youngjoon-lee youngjoon-lee marked this pull request as ready for review December 7, 2022 07:44
@youngjoon-lee youngjoon-lee linked an issue Dec 7, 2022 that may be closed by this pull request
@@ -0,0 +1,3 @@
package middleware

type ContextKeyAuthenticatedAccountAddress struct{}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

Base automatically changed from ft/15/start to main December 8, 2022 06:40
Copy link
Contributor

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngjoon-lee youngjoon-lee merged commit 9beb9d4 into main Dec 8, 2022
@youngjoon-lee youngjoon-lee deleted the ft/8/jwt branch December 8, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement JWT authentication (without nonce)
4 participants