Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change to use grpc client in tx builder #49

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix: change to use grpc client in tx builder #49

merged 1 commit into from
Dec 20, 2022

Conversation

0xHansLee
Copy link
Contributor

close #45

@0xHansLee 0xHansLee added this to the v2.1.0-beta milestone Dec 19, 2022
@0xHansLee 0xHansLee self-assigned this Dec 19, 2022
gyuguen
gyuguen approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

audtlr24
audtlr24 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I have one question. How about replacing the light client-based GetAddress that used in jwt or event handler?

youngjoon-lee
youngjoon-lee approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xHansLee 0xHansLee merged commit cbf91c0 into main Dec 20, 2022
@0xHansLee 0xHansLee deleted the ft/45 branch December 20, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audtlr24 audtlr24 audtlr24 approved these changes

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@inchori inchori Awaiting requested review from inchori

Assignees

@0xHansLee 0xHansLee

Labels
None yet
Projects
None yet
Milestone
v0.0.1-alpha.1
Development

Successfully merging this pull request may close these issues.

We don't need to use verifiedQueryClient for TxBuilder
4 participants
@0xHansLee @youngjoon-lee @gyuguen @audtlr24