Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error.loading.form.no_authorized when opening a form from tasks tab because context evaluates to false #8745

Closed
kennsippell opened this issue Dec 7, 2023 · 3 comments
Closed

error.loading.form.no_authorized when opening a form from tasks tab because context evaluates to false #8745

kennsippell opened this issue Dec 7, 2023 · 3 comments
Assignees
@dianabarsan
Labels
Priority: 0 - Critical Work on this right away. Regression Affects a feature that worked in a previous release Type: Bug Fix something that isn't working as intended
Milestone
4.4.2

Comments

@kennsippell
Copy link
Member

Describe the bug
There is a form with context: "false" in form.properties.json because this form should never appear on the contacts tab. In 3.x I am able to open this form via the tasks tab but in 4.x this throws error error.loading.form.no_authorized

To Reproduce

  1. Create a form with form.properties.json with context: "false"
  2. Create a task to trigger the form
  3. Trigger the task and click on it

Expected behavior
Form should open

Observed behavior
error.loading.form.no_authorized

Environment

  • Instance: CARES
  • App: webapp
  • Version: 4.4
@kennsippell kennsippell added Type: Bug Fix something that isn't working as intended Regression Affects a feature that worked in a previous release labels Dec 7, 2023
@kennsippell
Copy link
Member Author

Similar to #8589. Don't think it is the same though.

@kennsippell
Copy link
Member Author

This bug is blocking CARES app 4.x upgrade.

@dianabarsan dianabarsan added the Priority: 0 - Critical Work on this right away. label Dec 7, 2023
@dianabarsan dianabarsan mentioned this issue Dec 7, 2023
Merged
5 tasks
dianabarsan added a commit that referenced this issue Dec 8, 2023
@dianabarsan
fix(#8745): don't evaluate form context when opening a task (#8746)
34edb11 
#8745
dianabarsan added a commit that referenced this issue Dec 8, 2023
@dianabarsan
fix(#8745): don't evaluate form context when opening a task (#8746)
d875f9e 
#8745

(cherry picked from commit 34edb11)
@dianabarsan dianabarsan mentioned this issue Dec 8, 2023
Merged
5 tasks
@dianabarsan dianabarsan added this to the 4.4.2 milestone Dec 8, 2023
dianabarsan added a commit that referenced this issue Dec 8, 2023
@dianabarsan
fix(#8745): don't evaluate form context when opening a task (#8746)
f645946 
#8745

(cherry picked from commit 34edb11)
@dianabarsan dianabarsan mentioned this issue Dec 8, 2023
Merged
5 tasks
dianabarsan added a commit that referenced this issue Dec 11, 2023
@dianabarsan
fix(#8745): don't evaluate form context when opening a task (#8746)
f67e9d0 
#8745

(cherry picked from commit 34edb11)
dianabarsan added a commit that referenced this issue Dec 11, 2023
@dianabarsan
fix(#8745): don't evaluate form context when opening a task (#8746)
2b5cd23 
#8745

(cherry picked from commit 34edb11)
@dianabarsan
Copy link
Member

Merged to master and backported to 4.5.x and 4.4.x.

m5r pushed a commit that referenced this issue Dec 13, 2023
@dianabarsan @m5r
fix(#8745): don't evaluate form context when opening a task (#8746)
c01fb76 
#8745
m5r pushed a commit that referenced this issue Dec 13, 2023
@dianabarsan @m5r
fix(#8745): don't evaluate form context when opening a task (#8746)
969b849 
#8745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianabarsan dianabarsan

Labels
Priority: 0 - Critical Work on this right away. Regression Affects a feature that worked in a previous release Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
4.4.2
Development

No branches or pull requests
2 participants
@kennsippell @dianabarsan