fix(#7250): race condition in loading contacts

[latin-panda]

Description

Stores the contact ID we want to fetch. Then as promises resolve, it checks that the contact we want to load is the same as from the data we had retrieved.

#7250

Code review checklist

• Readable: Concise, well named, follows the style guide, documented if necessary.
• Documented: Configuration and user documentation on cht-docs
• Tested: Unit and/or e2e where appropriate
• Internationalised: All user facing text
• Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

• Core
• CouchDB Single
• CouchDB Cluster

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[latin-panda]

@ngaruko and @dianabarsan

There's a job before on this topic. The only part where we still need to check for the ID that it's loading is after the first retrieve of data.

Please have a look and let me know your thoughts.

[dianabarsan]

oops I accidentally hit enter without filling the textarea!

Thanks a lot for this change, @latin-panda ! It's great! I added a small request to keep code cleaner and a renaming suggestion.

[ngaruko]

Good work! Since it was affecting e2e and hard to reproduce, I guess we don't need to write any more e2e test, just monitor that we are getting stable builds from now on 🤞

[latin-panda]

@ngaruko I found the steps to reproduce the issue reliably; it's in the ticket.

[dianabarsan]

Nice, these things are such a pain. i think we should definitely normalize this kind of flow in all other areas where you could get subsequent select events, before initial ones finish executing.