Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#9489): collect telemetry for offline freetext searching #9525

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

feat(#9489): collect telemetry for offline freetext searching #9525

wants to merge 39 commits into from

Commits on Oct 23, 2024

  1. wip

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    991b281 View commit details
    Browse the repository at this point in the history

  2. remove unused code

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    77d84fd View commit details
    Browse the repository at this point in the history

  3. collect telemetry for searches against the contacts_by_freetext view

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    95a8b77 View commit details
    Browse the repository at this point in the history

  4. change telemetry key

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5cc183f View commit details
    Browse the repository at this point in the history

  5. wip reports_by_freetext

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    913b1fc View commit details
    Browse the repository at this point in the history

  6. wip contacts_by_type_freetext

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0e2cafd View commit details
    Browse the repository at this point in the history

  7. cleanup contacts_by_freetext telemetry

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b76d85e View commit details
    Browse the repository at this point in the history

  8. collect telemetry for searches against the reports_by_freetext view

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5d21f72 View commit details
    Browse the repository at this point in the history

  9. fix currentQuery being always equal to params.data.q since they s… 

    …hared the same scope
    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6b94414 View commit details
    Browse the repository at this point in the history

  10. freetextRequest.key never exists, I think we were looking for `free… 

    …textRequest.params.key`
    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    843888c View commit details
    Browse the repository at this point in the history

  11. collect telemetry for searches against the `contacts_by_type_freetext… 

    …` view
    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    de70aad View commit details
    Browse the repository at this point in the history

  12. fix test

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d7c322a View commit details
    Browse the repository at this point in the history

  13. e2e test for contact search telemetry

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bf001aa View commit details
    Browse the repository at this point in the history

  14. e2e test for report search telemetry

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b5e5ee4 View commit details
    Browse the repository at this point in the history

  15. e2e test for contact_by_type search telemetry

    @m5r
    m5r committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bffd0a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. return early

    @m5r
    m5r committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    abfd112 View commit details
    Browse the repository at this point in the history

  2. extract findMatchingProperties

    @m5r
    m5r committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5c241a7 View commit details
    Browse the repository at this point in the history

  3. ok sonar.

    @m5r
    m5r committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    cea6292 View commit details
    Browse the repository at this point in the history

  4. is sonar happy with contacts-content.component.ts?

    @m5r
    m5r committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5589861 View commit details
    Browse the repository at this point in the history

  5. is sonar happy with reports-content.component.ts too?

    @m5r
    m5r committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    19712b6 View commit details
    Browse the repository at this point in the history

  6. refactor 👍

    @m5r
    m5r committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a2d3fff View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. refactor extra select2:select event listener

    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    31d5b6b View commit details
    Browse the repository at this point in the history

  2. don't bother looping over the doc fields when we have a key:value c… 

    …olon query
    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a5a3b98 View commit details
    Browse the repository at this point in the history

  3. move propertyPath initialization

    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ab8d9e5 View commit details
    Browse the repository at this point in the history

  4. revert db after telemetry test

    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b6e3b6b View commit details
    Browse the repository at this point in the history

  5. use void keyword to mark promises as intentionally not awaited

    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    bca463f View commit details
    Browse the repository at this point in the history

  6. fix telemetry test

    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ef1918a View commit details
    Browse the repository at this point in the history

  7. fix select2-search telemetry

    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6cdb9cc View commit details
    Browse the repository at this point in the history

  8. remove void operator and add comment why we're not awaiting the pro… 

    …mise
    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e59da86 View commit details
    Browse the repository at this point in the history

  9. handle select2search case where it calls contacts_by_freetext

    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    4b59c92 View commit details
    Browse the repository at this point in the history

  10. for..of => Promise.all

    @m5r
    m5r committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    156457a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. unit test report search telemetry

    @m5r
    m5r committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    06a86b5 View commit details
    Browse the repository at this point in the history

  2. unit test contact search telemetry

    @m5r
    m5r committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ab8bf82 View commit details
    Browse the repository at this point in the history

  3. add e2e test for select2 without contact type

    @m5r
    m5r committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3ff8d1c View commit details
    Browse the repository at this point in the history

  4. clean up e2e test

    @m5r
    m5r committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8bcd070 View commit details
    Browse the repository at this point in the history

  5. wow is sonar finally happy with void here?

    @m5r
    m5r committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2e75674 View commit details
    Browse the repository at this point in the history

  6. oops forgot some leftovers to clean up

    @m5r
    m5r committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    32ddecc View commit details
    Browse the repository at this point in the history

  7. clean up telemetry db before running our telemetry tests

    @m5r
    m5r committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    857203f View commit details
    Browse the repository at this point in the history

  8. clean up telemetry db after each telemetry tests

    @m5r
    m5r committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e795d34 View commit details
    Browse the repository at this point in the history