Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typeorm): Upgrade Typeorm to V3 #2563

Closed
wants to merge 1 commit into from
Closed

feat(typeorm): Upgrade Typeorm to V3 #2563

wants to merge 1 commit into from

Conversation

juanzgc
Copy link
Contributor

@juanzgc juanzgc commented Nov 8, 2022

This PR references #2294 so all credit to Adrien for laying the groundwork.

Unfortunately, migrating Typeorm becomes very difficult as new code continues to be committed. Therefore, I created this PR which only focuses on the migration. This PR limits the amount of code changes in the Service and Repository repos to prevent as many painful merge conflicts.

I believe with this PR we can actually move forward with migrating to Typeorm V3.

The overall goal is to eventually fix: #2054 which I believe will improve Developer Experience when using the medusa-extender.

This PR references #2294 so all credit to Adrien.

Unfortunately, migrating Typeorm becomes very difficult as new code continues to be committed. Therefore, I created this PR which **only** focuses on the migration. This PR limits the amount of code changes
in the Service and Repository repos to prevent **as many** painful merge conflicts.

I believe with this PR we can actually move forward with migrating to Typeorm V3.

The overall goal is to eventually fix: #2054 which I believe will improve Developer Experience when using the medusa-extender.
@juanzgc juanzgc requested a review from a team as a code owner November 8, 2022 03:10
@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

⚠️ No Changeset found

Latest commit: 52c3071

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juanzgc
Copy link
Contributor Author

juanzgc commented Nov 8, 2022

@adrien2p Hopefully this helps a bit with the painful migration 😇 I tried my best to limit the amount of possible merge conflicts to make migrating actually doable

Thanks to your new buildQuery util this was made possibly 😄 It's also important to note we don't require updating the current format of relations since Typeorm V3 can handle both formats.

@mariusa
Copy link

mariusa commented Jan 3, 2023

@olivermrbl could this be considered, please? The longer it waits, the more painful to rebase. Thanks

@olivermrbl
Copy link
Contributor

@mariusa Sorry for letting your message hang. We are discussing the migration this week and will hopefully be able to get back to you with a clear timeline for when this will be prioritized and eventually released :)

@olivermrbl
Copy link
Contributor

@juanzgc We highly appreciate your contributions to the migration. We will use your branch as a foundation for continuing the work, but split it into smaller, isolated PRs, that are easier to review.

We expect the migration to be finalized mid next week.

Closing for now.

@olivermrbl olivermrbl closed this Jan 16, 2023
@juanzgc
Copy link
Contributor Author

juanzgc commented Jan 16, 2023

@olivermrbl Thanks Oliver for prioritizing the Typeorm migration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Migration TypeORM
3 participants