-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): Load PaymentProcessors + integrate in PaymentProviderService #2978
Conversation
🦋 Changeset detectedLatest commit: 230dc84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9bf1410
to
9315e2a
Compare
2269ff3
to
1e18356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@olivermrbl do you think it is ready to be merged? |
Will have a look at it later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong work. Only minor todos and questions :)
…edusajs/medusa into feat/payment-processor-loader-provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…edusajs/medusa into feat/payment-processor-loader-provider t pudh
@adrien2p Feel free to merge as you please 🚢 |
What
The loader should be able to load a payment processor.
The payment provider should be able to handle both cases, using a payment service or a payment processor and it should stay invisible to the end user at the moment.
The errors returned by the payment processor should be handled within the core and gracefully managed.
FIXES CORE-978