Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Load PaymentProcessors + integrate in PaymentProviderService #2978

Merged
merged 28 commits into from
Feb 21, 2023

Conversation

adrien2p
Copy link
Member

What

The loader should be able to load a payment processor.

The payment provider should be able to handle both cases, using a payment service or a payment processor and it should stay invisible to the end user at the moment.

The errors returned by the payment processor should be handled within the core and gracefully managed.

FIXES CORE-978

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: 230dc84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/medusa Patch
@medusajs/inventory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p adrien2p changed the title feat: Add payment process support into the loader and payment provider feat: Add payment processor support into the loader and payment provider Jan 10, 2023
@adrien2p adrien2p force-pushed the feat/payment-processor-loader-provider branch 6 times, most recently from 9bf1410 to 9315e2a Compare January 11, 2023 13:19
@adrien2p adrien2p force-pushed the feat/payment-processor-loader-provider branch 2 times, most recently from 2269ff3 to 1e18356 Compare January 26, 2023 08:29
@adrien2p adrien2p marked this pull request as ready for review January 26, 2023 08:30
@adrien2p adrien2p requested a review from a team as a code owner January 26, 2023 08:30
@adrien2p adrien2p requested a review from olivermrbl January 26, 2023 08:31
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/medusa/src/loaders/defaults.ts Outdated Show resolved Hide resolved
@adrien2p adrien2p requested review from olivermrbl and removed request for olivermrbl February 7, 2023 11:34
@adrien2p
Copy link
Member Author

@olivermrbl do you think it is ready to be merged?

@olivermrbl
Copy link
Contributor

Will have a look at it later today

@olivermrbl olivermrbl changed the title feat: Add payment processor support into the loader and payment provider feat(medusa): PaymentProcessor support in loaders Feb 17, 2023
@olivermrbl olivermrbl changed the title feat(medusa): PaymentProcessor support in loaders feat(medusa): Load in PaymentProcessors Feb 17, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong work. Only minor todos and questions :)

packages/medusa/src/loaders/defaults.ts Show resolved Hide resolved
packages/medusa/src/loaders/defaults.ts Outdated Show resolved Hide resolved
packages/medusa/src/loaders/helpers/plugins.ts Outdated Show resolved Hide resolved
packages/medusa/src/loaders/helpers/plugins.ts Outdated Show resolved Hide resolved
packages/medusa/src/loaders/plugins.ts Show resolved Hide resolved
packages/medusa/src/services/payment-provider.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/payment-provider.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl changed the title feat(medusa): Load in PaymentProcessors feat(medusa): Load PaymentProcessors + integrate in PaymentProviderService Feb 17, 2023
@adrien2p adrien2p requested a review from olivermrbl February 20, 2023 10:15
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl
Copy link
Contributor

@adrien2p Feel free to merge as you please 🚢

@adrien2p adrien2p merged commit f43e9f0 into develop Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants