This repository has been archived by the owner on Nov 21, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat(admin-ui): add table, hint, form, and initial work on data table #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
StephixOne
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though a DataTable block or at least example will be very useful whenever we can get to it, for a more batteries-included approach.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
What are blocks
Blocks are "batteries included" components that usually will consist of multiple "dumb" components from the components folder, as well as implement some API.
This PR contains a Form block that contains components that help with setting up forms the "admin way" using
react-hook-form
. The components ensure that correct IDs are created and set for related components, as well as ensure that the form is accessible.The PR also contains initial work on a DataTable block, which is a generic Table component that uses
@tanstack/react-table
to set up a Table that can be either controlled or uncontrolled. The implementation is still WIP so the component is not exported atm.