Skip to content

Commit

Permalink
Backport PR voila-dashboards#1334: Do not clean up resources after ex…
Browse files Browse the repository at this point in the history
…ecution
  • Loading branch information
martinRenou authored and meeseeksmachine committed Jun 22, 2023
1 parent 0880523 commit c0b80ab
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions voila/notebook_renderer.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,6 @@ async def _jinja_notebook_execute(self, nb, kernel_id):
# (it seems to be local to our block)
nb.cells = result.cells

await self._cleanup_resources()

async def _jinja_cell_generator(self, nb, kernel_id):
"""Generator that will execute a single notebook cell at a time"""
nb, _ = ClearOutputPreprocessor().preprocess(
Expand Down Expand Up @@ -302,12 +300,6 @@ async def _jinja_cell_generator(self, nb, kernel_id):
finally:
yield output_cell

await self._cleanup_resources()

async def _cleanup_resources(self):
await ensure_async(self.executor.km.cleanup_resources())
await ensure_async(self.executor.kc.stop_channels())

async def load_notebook(self, path):

model = await ensure_async(self.contents_manager.get(path=path))
Expand Down

0 comments on commit c0b80ab

Please sign in to comment.