Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only secure protocols/ciphers in janus_http #1219

Closed
wants to merge 2 commits into from
Closed

Allow only secure protocols/ciphers in janus_http #1219

wants to merge 2 commits into from

Conversation

agclark27
Copy link
Contributor

Set MHD_OPTION_HTTPS_PRIORITIES to "PFS:-VERS-TLS1.0:-VERS-TLS1.1:-3DES-CBC:-ARCFOUR-128" to disable insecure protocols and ciphers (e.g., SSL 3.0, TLS 1.0), since browsers that support WebRTC all support secure protocols/ciphers. Enables any Janus HTTPS endpoint to pass network scans and PCI validations by disabling insecure protocols and ciphers.

Set MHD_OPTION_HTTPS_PRIORITIES to "PFS:-VERS-TLS1.0:-VERS-TLS1.1:-3DES-CBC:-ARCFOUR-128" to disable insecure protocols and ciphers (e.g., SSL 3.0, TLS 1.0), since browsers that support WebRTC all support secure protocols/ciphers. Enables any Janus HTTPS endpoint to pass network scans and PCI validations by disabling insecure protocols and ciphers.
Allow only secure protocols/ciphers in janus_http
@lminiero
Copy link
Member

lminiero commented May 1, 2018

Can this cause issues with some clients? The ciphers endpoints use for WebRTC use a different stack than the one used for HTTPS, so I wouldn't want things to stop working for, e.g., mobile apps because of this.

@agclark27
Copy link
Contributor Author

All of the reference browsers (Chrome, Safari, Firefox, Edge) that support WebRTC all support TLS 1.2 and secure/non-weak ciphers, but I'm happy to re-submit this as a configuration parameter so that it's opt-in if that would be preferable. The default cipher string could be sent if the parameter isn't configured so that there is no behavior change for existing installations.

@lminiero
Copy link
Member

lminiero commented May 4, 2018

A configuration parameter would help, thanks! Typically it's not just browsers that talk to Janus, so having flexibility to override those defaults would be helpful.

@lminiero
Copy link
Member

lminiero commented May 4, 2018

Wondering if we should have the same in the WebSockets library too. Checking the documentation it looks like this can be done setting the ssl_cipher_list property, which I guess works pretty much the same way as MHD_OPTION_HTTPS_PRIORITIES does. (Note: not saying you'll have to do it, I can do that after we merge).

@lminiero
Copy link
Member

lminiero commented May 9, 2018

@agclark81 did you have time to make that configurable? As soon as that's ready, I think this is good to merge.

lminiero added a commit that referenced this pull request May 11, 2018
@lminiero
Copy link
Member

@agclark81 since it was a simple enough change, I made it configurable myself. I mentioned you in the commit description, since this was indeed your contribution. Closing this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants