Early add a reference to a subscriber in videoroom handler. #2253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix a race condition that might occur in the videoroom plugin when a subscriber gets destroyed while the plugin thread is handling a subscriber message.
The proposed fix is to early add a reference to the subscriber in the message handler while the
sessions_mutex
is stil taken by the thread. This should avoidheap-use-after-free
errors when trying to access a freed subscriber later in the handler code.