Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings API - Feedback #1520

Closed
gmourier opened this issue Mar 16, 2022 · 1 comment · Fixed by #1633
Closed

Settings API - Feedback #1520

gmourier opened this issue Mar 16, 2022 · 1 comment · Fixed by #1633

Comments

@gmourier
Copy link
Member

gmourier commented Mar 16, 2022

Hi @meilisearch/docs-team!

While writing the catch-up specification for the Settings API, I took the opportunity to write down some little details I noticed on the documentation that might interest you.

Reindexing Documents On Settings Change

In the filterableAttributes API Reference, it is mentioned that updating the setting will re-index documents but this is not mentioned on other settings API Reference.

Changing any of the following index settings will cause documents to be re-indexed:

  • searchableAttributes
  • filterableAttributes
  • sortableAttributes
  • distinctAttribute
  • stopWords

You may want to mention that for consistency.

Missing Description

Location: https://docs.meilisearch.com/learn/configuration/settings.html#index-settings

sortableAttributes seems missing a proper description.

@dichotommy
Copy link
Contributor

Thank you @gmourier , this is very useful feedback! 🙌🏻

bors bot added a commit that referenced this issue May 25, 2022
1633: update settings api r=maryamsulemani97 a=maryamsulemani97

closes #1520 

Co-authored-by: Maryam Sulemani <maryam@meilisearch.com>
@bors bors bot closed this as completed in bb3b847 May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants