Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28 hebrew tokenizer #1728

Merged
merged 9 commits into from
Jul 7, 2022
Merged

v0.28 hebrew tokenizer #1728

merged 9 commits into from
Jul 7, 2022

Conversation

dichotommy
Copy link
Contributor

@dichotommy dichotommy commented Jun 15, 2022 •
edited
Loading

Update language and tokenization pages for v0.28. Related to #1688

@dichotommy dichotommy changed the base branch from master to v0.28 June 15, 2022 08:54
@dichotommy
Update tokenization page (four total pipelines
85227a7 
Also reduce technical complexity of language page (no need to mention specific normalizers + segmenters)
@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 15, 2022
@guimachiavelli guimachiavelli linked an issue Jun 21, 2022 that may be closed by this pull request
v0.28: Hebrew language support #1688
Closed
@guimachiavelli
Copy link
Member

Is this ready for review? If not, what are we missing?

@dichotommy dichotommy marked this pull request as ready for review June 23, 2022 13:28
guimachiavelli
guimachiavelli approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I will request an SME review once the programmer responsible for this returns from his holidays.

@guimachiavelli guimachiavelli mentioned this pull request Jun 30, 2022
Closed
17 tasks
ManyTheFish
ManyTheFish requested changes Jul 5, 2022
View reviewed changes
learn/what_is_meilisearch/language.md Outdated Show resolved Hide resolved
learn/what_is_meilisearch/language.md Outdated Show resolved Hide resolved
@maryamsulemani97 maryamsulemani97 self-assigned this Jul 5, 2022
maryamsulemani97 and others added 2 commits July 5, 2022 16:32
@maryamsulemani97 @ManyTheFish
Apply suggestions from code review
dc61d8f 
Co-authored-by: Many the fish <many@meilisearch.com>
@maryamsulemani97
update based on ManyTheFish's review
0425a22
@maryamsulemani97 @guimachiavelli
Update learn/advanced/tokenization.md
29b9d16 
Co-authored-by: gui machiavelli <gui@meilisearch.com>
ManyTheFish
ManyTheFish requested changes Jul 7, 2022
View reviewed changes
learn/what_is_meilisearch/language.md Outdated Show resolved Hide resolved
@maryamsulemani97 @ManyTheFish
Update learn/what_is_meilisearch/language.md
b07336f 
Co-authored-by: Many the fish <many@meilisearch.com>
@guimachiavelli guimachiavelli merged commit d880d3b into v0.28 Jul 7, 2022
@guimachiavelli guimachiavelli deleted the v0.28-hebrew-tokenizer branch July 7, 2022 13:24
@guimachiavelli guimachiavelli mentioned this pull request Jul 7, 2022
Merged
bors bot added a commit that referenced this pull request Jul 7, 2022
@bors @guimachiavelli
Merge #1769
e1ec26f 
1769: v0.28: Update "create issue" link r=guimachiavelli a=guimachiavelli

As requested on #1728 (comment)

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryamsulemani97 maryamsulemani97 maryamsulemani97 left review comments

@curquiza curquiza curquiza left review comments

@guimachiavelli guimachiavelli guimachiavelli approved these changes

@ManyTheFish ManyTheFish ManyTheFish requested changes

Assignees

@maryamsulemani97 maryamsulemani97

Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging this pull request may close these issues.

v0.28: Hebrew language support
5 participants
@dichotommy @guimachiavelli @ManyTheFish @curquiza @maryamsulemani97