-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.28: Pagination guide #1753
v0.28: Pagination guide #1753
Conversation
@dichotommy: I know you're short on time, so these are the areas I'm mostly interested in receiving feedback:
Of course, any feedback is appreciated, especially if you identify any other major areas of concern I'm not aware of because I'm too much inside the subject atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a solid start to me. The implementation sections should probably be broken up a bit. Curious about why infinite scroll wasn't offered as an option. Too much labor to create code samples for it?
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
@bidoubiwa and @gmourier: This is the first draft of the pagination guide. As we discussed, I adapted your original article into something a bit more focussed on explaining why page selectors are not a good fit for Meilisearch and directing users to a recommended solution. Instructions for reviewersAs usual, all feedback is welcome, but if you're on a rush, what I need the most from you is:
Other pagination methods@dichotommy has suggested adding the other pagination methods (e.g. infinite scrolling). While I'm not opposed to it, I am concerned that this guide might already be too long. Perhaps we could make smaller guides with instructions on how to implement other UIs in the future? CI errorsYou can safely ignore those, as they're related to links to pages created in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks to consider for SEO and internal knowledge and some very light rephrasing suggestions. You do what you want with it Gui, you are the master on board.
Thank you very much for this guide. 🏆
Is all the information there correct? Code samples very much included;
I didn't look at the code samples in detail. @bidoubiwa will have a better eye than me. Other than that, everything seems correct!
Do you think we need a code sample for the limit workaround (L#112)?
I don't think so but again @bidoubiwa will have a better suggestion than me since she experienced a lot of back and forth with struggling users over time around this subject.
@dichotommy has suggested adding the other pagination methods (e.g. infinite scrolling). While I'm not opposed to it, I am concerned that this guide might already be too long. Perhaps we could make smaller guides with instructions on how to implement other UIs in the future?
The main goal as we discussed @guimachiavelli is to indicate to users that a page selection is to be avoided while giving a workaround. It seems to me to be brilliantly done.
We can absolutely add other methods in the future and why not in a much more advanced guide within a resource center.
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pointing out that the images are still in the file changes.
Thank you for this guide @guimachiavelli and thanks to you @bidoubiwa for the code snippets. Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🦅 Just a few changes
- I think you forgot to add
'/learn/advanced/pagination',
toconfig.js
- Should we use
"Previous" and "Next" buttons
instead ofprevious and next buttons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide is exactly what I expected to help the users do the migration btw v0.27.0 and v0.28.0, following the nbHits
change! Thank you very much! Will be definitely helpful!
Will this guide's link be |
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
@maryamsulemani97: thanks for both suggestions 👍 @curquiza: yes, the final link should be Also, the good stuff here can be directly attributed to @gmourier and @bidoubiwa ❤️. I only cleaned up things a bit and made the text shorter to make it less intimidating for users. |
bors merge |
Build failed: |
Closes #561