Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.28: Telemetry updates #1763

Merged
merged 2 commits into from
Jul 5, 2022
Merged

v0.28: Telemetry updates #1763

merged 2 commits into from
Jul 5, 2022

Conversation

maryamsulemani97
Copy link
Contributor

closes #1693

@guimachiavelli guimachiavelli mentioned this pull request Jun 30, 2022
17 tasks
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧚‍♂️

@gmourier, can you confirm these are all the new datapoints?

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change added in this PR?
meilisearch/meilisearch#2367

@maryamsulemani97
Copy link
Contributor Author

maryamsulemani97 commented Jun 30, 2022

Is this change added in this PR?
meilisearch/meilisearch#2367

No, confirmed with @gmourier said we didn't need to

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then!

@maryamsulemani97
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 5, 2022

Build succeeded:

@bors bors bot merged commit 52dcfd0 into v0.28 Jul 5, 2022
@bors bors bot deleted the v0.28--Telemetry-updates branch July 5, 2022 11:38
@gmourier
Copy link
Member

gmourier commented Jul 6, 2022

Sorry, I'm late to the party but everything seems well! Thanks @maryamsulemani97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants